Add a pre-container assembly verification for detecting failing plugins

Apart from small optimization, this avoids the problem of starting IPC server if one of the assemblies fail to load (as ASF will abort the rest of the plugins loading routine, and therefore no plugins will be loaded at all).

.github/workflows/ci.yml

@@ -133,9 +133,9 @@ jobs:
             fi
 
             # If we're including SteamTokenDumper plugin for this framework, copy it to output directory
-            if [ -f "out/${STEAM_TOKEN_DUMPER_NAME}/${NET_CORE_VERSION}/${STEAM_TOKEN_DUMPER_NAME}.dll" ]; then
+            if [ -d "out/${STEAM_TOKEN_DUMPER_NAME}/${NET_CORE_VERSION}" ]; then
                 mkdir -p "out/${1}/plugins/${STEAM_TOKEN_DUMPER_NAME}"
-                cp "out/${STEAM_TOKEN_DUMPER_NAME}/${NET_CORE_VERSION}/${STEAM_TOKEN_DUMPER_NAME}.dll" "out/${1}/plugins/${STEAM_TOKEN_DUMPER_NAME}"
+                cp -pR "out/${STEAM_TOKEN_DUMPER_NAME}/${NET_CORE_VERSION}/"* "out/${1}/plugins/${STEAM_TOKEN_DUMPER_NAME}"
             fi
 
             # Include .ico file for all platforms, since only Windows script can bundle it inside the exe
@@ -208,12 +208,12 @@ jobs:
             }
 
             # If we're including SteamTokenDumper plugin for this framework, copy it to output directory
-            if (Test-Path "out\$env:STEAM_TOKEN_DUMPER_NAME\$targetFramework\$env:STEAM_TOKEN_DUMPER_NAME.dll" -PathType Leaf) {
+            if (Test-Path "out\$env:STEAM_TOKEN_DUMPER_NAME\$targetFramework" -PathType Container) {
                 if (!(Test-Path "out\$variant\plugins\$env:STEAM_TOKEN_DUMPER_NAME" -PathType Container)) {
                     New-Item -ItemType Directory -Path "out\$variant\plugins\$env:STEAM_TOKEN_DUMPER_NAME" > $null
                 }
 
-                Copy-Item "out\$env:STEAM_TOKEN_DUMPER_NAME\$targetFramework\$env:STEAM_TOKEN_DUMPER_NAME.dll" "out\$variant\plugins\$env:STEAM_TOKEN_DUMPER_NAME"
+                Copy-Item "out\$env:STEAM_TOKEN_DUMPER_NAME\$targetFramework\*" "out\$variant\plugins\$env:STEAM_TOKEN_DUMPER_NAME"
             }
 
             # Icon is available only in .NET Framework and .NET Core Windows build, we'll bundle the .ico file for other flavours

.travis.yml

@@ -66,9 +66,9 @@ script:
         fi
 
         # If we're including SteamTokenDumper plugin for this framework, copy it to output directory
-        if [ -f "out/${STEAM_TOKEN_DUMPER_NAME}/${NET_CORE_VERSION}/${STEAM_TOKEN_DUMPER_NAME}.dll" ]; then
+        if [ -d "out/${STEAM_TOKEN_DUMPER_NAME}/${NET_CORE_VERSION}" ]; then
             mkdir -p "out/${1}/plugins/${STEAM_TOKEN_DUMPER_NAME}"
-            cp "out/${STEAM_TOKEN_DUMPER_NAME}/${NET_CORE_VERSION}/${STEAM_TOKEN_DUMPER_NAME}.dll" "out/${1}/plugins/${STEAM_TOKEN_DUMPER_NAME}"
+            cp -pR "out/${STEAM_TOKEN_DUMPER_NAME}/${NET_CORE_VERSION}/"* "out/${1}/plugins/${STEAM_TOKEN_DUMPER_NAME}"
         fi
 
         # Include .ico file for all platforms, since only Windows script can bundle it inside the exe

ArchiSteamFarm.CustomPlugins.ExamplePlugin/ArchiSteamFarm.CustomPlugins.ExamplePlugin.csproj

@@ -4,12 +4,17 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="ConfigureAwaitChecker.Analyzer" Version="4.0.0">
+    <PackageReference Include="ConfigureAwaitChecker.Analyzer" PrivateAssets="all" Version="4.0.0" />
-      <PrivateAssets>all</PrivateAssets>
+    <PackageReference Include="Newtonsoft.Json" IncludeAssets="compile" Version="*" />
-    </PackageReference>
+    <PackageReference Include="SteamKit2" IncludeAssets="compile" Version="*" />
+    <PackageReference Include="System.Composition.AttributedModel" IncludeAssets="compile" Version="*" />
+  </ItemGroup>
+
+  <ItemGroup Condition="'$(TargetFramework)' == 'net48'">
+    <PackageReference Include="Microsoft.AspNetCore.Mvc.Core" IncludeAssets="compile" Version="*" />
   </ItemGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\ArchiSteamFarm\ArchiSteamFarm.csproj" />
+    <ProjectReference Include="..\ArchiSteamFarm\ArchiSteamFarm.csproj" ExcludeAssets="all" Private="false" />
   </ItemGroup>
 </Project>

ArchiSteamFarm.CustomPlugins.PeriodicGC/ArchiSteamFarm.CustomPlugins.PeriodicGC.csproj

@@ -4,12 +4,11 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="ConfigureAwaitChecker.Analyzer" Version="4.0.0">
+    <PackageReference Include="ConfigureAwaitChecker.Analyzer" PrivateAssets="all" Version="4.0.0" />
-      <PrivateAssets>all</PrivateAssets>
+    <PackageReference Include="System.Composition.AttributedModel" IncludeAssets="compile" Version="*" />
-    </PackageReference>
   </ItemGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\ArchiSteamFarm\ArchiSteamFarm.csproj" />
+    <ProjectReference Include="..\ArchiSteamFarm\ArchiSteamFarm.csproj" ExcludeAssets="all" Private="false" />
   </ItemGroup>
 </Project>

ArchiSteamFarm.OfficialPlugins.SteamTokenDumper/ArchiSteamFarm.OfficialPlugins.SteamTokenDumper.csproj

@@ -4,12 +4,18 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="ConfigureAwaitChecker.Analyzer" Version="4.0.0">
+    <PackageReference Include="ConfigureAwaitChecker.Analyzer" PrivateAssets="all" Version="4.0.0" />
-      <PrivateAssets>all</PrivateAssets>
+    <PackageReference Include="Newtonsoft.Json" IncludeAssets="compile" Version="*" />
-    </PackageReference>
+    <PackageReference Include="SteamKit2" IncludeAssets="compile" Version="*" />
+    <PackageReference Include="Swashbuckle.AspNetCore.Annotations" IncludeAssets="compile" Version="*" />
+    <PackageReference Include="System.Composition.AttributedModel" IncludeAssets="compile" Version="*" />
+  </ItemGroup>
+
+  <ItemGroup Condition="'$(TargetFramework)' == 'net48'">
+    <PackageReference Include="System.Collections.Immutable" IncludeAssets="compile" Version="*" />
   </ItemGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\ArchiSteamFarm\ArchiSteamFarm.csproj" />
+    <ProjectReference Include="..\ArchiSteamFarm\ArchiSteamFarm.csproj" ExcludeAssets="all" Private="false" />
   </ItemGroup>
 </Project>

ArchiSteamFarm.Tests/ArchiSteamFarm.Tests.csproj

@@ -4,9 +4,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="ConfigureAwaitChecker.Analyzer" Version="4.0.0">
+    <PackageReference Include="ConfigureAwaitChecker.Analyzer" PrivateAssets="all" Version="4.0.0" />
-      <PrivateAssets>all</PrivateAssets>
-    </PackageReference>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.0" />
     <PackageReference Include="MSTest.TestAdapter" Version="2.1.2" />
     <PackageReference Include="MSTest.TestFramework" Version="2.1.2" />

ArchiSteamFarm/ArchiSteamFarm.csproj

@@ -8,9 +8,7 @@
 
   <ItemGroup>
     <PackageReference Include="AngleSharp.XPath" Version="1.1.7" />
-    <PackageReference Include="ConfigureAwaitChecker.Analyzer" Version="4.0.0">
+    <PackageReference Include="ConfigureAwaitChecker.Analyzer" PrivateAssets="all" Version="4.0.0" />
-      <PrivateAssets>all</PrivateAssets>
-    </PackageReference>
     <PackageReference Include="CryptSharpStandard" Version="1.0.0" />
     <PackageReference Include="Humanizer" Version="2.8.26" />
     <PackageReference Include="JetBrains.Annotations" Version="2020.1.0" />
@@ -42,12 +40,8 @@
     <PackageReference Include="Microsoft.AspNetCore.WebSockets" Version="2.2.1" />
     <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="5.0.0" />
     <PackageReference Include="Microsoft.Extensions.Logging.Configuration" Version="5.0.0" />
-    <Reference Include="System.Net.Http">
+    <Reference Include="System.Net.Http" HintPath="C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.8\System.Net.Http.dll" />
-      <HintPath>C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.8\System.Net.Http.dll</HintPath>
+    <Reference Include="System.Security" HintPath="C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.8\System.Security.dll" />
-    </Reference>
-    <Reference Include="System.Security">
-      <HintPath>C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.8\System.Security.dll</HintPath>
-    </Reference>
   </ItemGroup>
 
   <ItemGroup>

ArchiSteamFarm/ArchiWebHandler.cs

@@ -311,9 +311,10 @@ namespace ArchiSteamFarm {
 
 						// ReSharper disable once AccessToDisposedClosure
 						async () => await iPlayerService.CallAsync(
-							HttpMethod.Get, "GetOwnedGames", args: new Dictionary<string, object>(3, StringComparer.Ordinal) {
+							HttpMethod.Get, "GetOwnedGames", args: new Dictionary<string, object>(4, StringComparer.Ordinal) {
 								{ "include_appinfo", 1 },
 								{ "key", steamApiKey! },
+								{ "skip_unvetted_apps", "0" },
 								{ "steamid", steamID }
 							}
 						).ConfigureAwait(false)

ArchiSteamFarm/IPC/Startup.cs

@@ -248,11 +248,13 @@ namespace ArchiSteamFarm.IPC {
 #endif
 
 			// Add support for controllers declared in custom plugins
-			HashSet<Assembly>? assemblies = PluginsCore.LoadAssemblies();
+			if (PluginsCore.ActivePlugins?.Count > 0) {
+				HashSet<Assembly>? assemblies = PluginsCore.LoadAssemblies();
 
-			if (assemblies != null) {
+				if (assemblies != null) {
-				foreach (Assembly assembly in assemblies) {
+					foreach (Assembly assembly in assemblies) {
-					mvc.AddApplicationPart(assembly);
+						mvc.AddApplicationPart(assembly);
+					}
 				}
 			}
 

ArchiSteamFarm/Localization/Strings.pt-BR.resx

@@ -736,6 +736,10 @@ Tempo de execução: {1}</value>
     <value>Resultado: {0}</value>
     <comment>{0} will be replaced by generic result of various functions that use this string</comment>
   </data>
-  
+  <data name="WarningUnsupportedEnvironment" xml:space="preserve">
-  
+    <value>Você está tentando executar a variante {0} do ASF em um ambiente não suportado: {1}. Forneça o arguimento --ignore-unsupported-environment se você realmente sabe o que está fazendo.</value>
+  </data>
+  <data name="WarningUnknownCommandLineArgument" xml:space="preserve">
+    <value>Argumento de linha de comando desconhecido: {0}</value>
+  </data>
 </root>

ArchiSteamFarm/Plugins/PluginsCore.cs

@@ -101,6 +101,20 @@ namespace ArchiSteamFarm.Plugins {
 
 			ASF.ArchiLogger.LogGenericInfo(string.Format(CultureInfo.CurrentCulture, Strings.Initializing, nameof(Plugins)));
 
+			foreach (Assembly assembly in assemblies) {
+				ASF.ArchiLogger.LogGenericDebug(string.Format(CultureInfo.CurrentCulture, Strings.Initializing, assembly.FullName));
+
+				try {
+					// This call is bare minimum to verify if the assembly can load itself
+					assembly.GetTypes();
+				} catch (Exception e) {
+					ASF.ArchiLogger.LogGenericError(string.Format(CultureInfo.CurrentCulture, Strings.WarningFailedWithError, assembly.FullName));
+					ASF.ArchiLogger.LogGenericException(e);
+
+					return false;
+				}
+			}
+
 			ConventionBuilder conventions = new();
 			conventions.ForTypesDerivedFrom<IPlugin>().Export<IPlugin>();
 

ArchiSteamFarm/Program.cs

@@ -185,17 +185,13 @@ namespace ArchiSteamFarm {
 			Console.Title = SharedInfo.ProgramIdentifier;
 			ASF.ArchiLogger.LogGenericInfo(SharedInfo.ProgramIdentifier);
 
-			if (!OS.VerifyEnvironment()) {
+			if (!IgnoreUnsupportedEnvironment) {
-				string errorMessage = string.Format(CultureInfo.CurrentCulture, Strings.WarningUnsupportedEnvironment, SharedInfo.BuildInfo.Variant, OS.Variant);
+				if (!OS.VerifyEnvironment()) {
-
+					ASF.ArchiLogger.LogGenericError(string.Format(CultureInfo.CurrentCulture, Strings.WarningUnsupportedEnvironment, SharedInfo.BuildInfo.Variant, OS.Variant));
-				if (!IgnoreUnsupportedEnvironment) {
-					ASF.ArchiLogger.LogGenericError(errorMessage);
 					await Task.Delay(10000).ConfigureAwait(false);
 
 					return false;
 				}
-
-				ASF.ArchiLogger.LogGenericWarning(errorMessage);
 			}
 
 			return true;

Directory.Build.props

@@ -1,6 +1,6 @@
 <Project>
   <PropertyGroup>
-    <Version>5.0.0.4</Version>
+    <Version>5.0.1.0</Version>
   </PropertyGroup>
 
   <PropertyGroup>

appveyor.yml

@@ -239,12 +239,12 @@ after_test:
         }
 
         # If we're including SteamTokenDumper plugin for this framework, copy it to output directory
-        if (Test-Path "out\$env:STEAM_TOKEN_DUMPER_NAME\$targetFramework\$env:STEAM_TOKEN_DUMPER_NAME.dll" -PathType Leaf) {
+        if (Test-Path "out\$env:STEAM_TOKEN_DUMPER_NAME\$targetFramework" -PathType Container) {
             if (!(Test-Path "out\$variant\plugins\$env:STEAM_TOKEN_DUMPER_NAME" -PathType Container)) {
                 New-Item -ItemType Directory -Path "out\$variant\plugins\$env:STEAM_TOKEN_DUMPER_NAME" > $null
             }
 
-            Copy-Item "out\$env:STEAM_TOKEN_DUMPER_NAME\$targetFramework\$env:STEAM_TOKEN_DUMPER_NAME.dll" "out\$variant\plugins\$env:STEAM_TOKEN_DUMPER_NAME"
+            Copy-Item "out\$env:STEAM_TOKEN_DUMPER_NAME\$targetFramework\*" "out\$variant\plugins\$env:STEAM_TOKEN_DUMPER_NAME"
         }
 
         # Icon is available only in .NET Framework and .NET Core Windows build, we'll bundle the .ico file for other flavours