JustArchi
772607b680
Use recommended async dispose pattern
...
Funny enough, non-breaking API changes since all of those classes are sealed.
2022-06-19 18:24:52 +02:00
Sebastian Göls
b8bfcd5df3
Simplify LogNullError calls ( #2554 )
...
* Remove necessity of nameof(...) in calls to ArchiLogger.LogNullError(...)
* Upgrade Madness
* Upgrade Madness
* Split up compound null log statements
2022-04-13 23:16:36 +02:00
Archi
ec78ad1ac2
Add overflow-related fixes and improvements
2022-04-02 16:00:07 +02:00
Archi
dae6f9d328
Use newer syntax for Enum.IsDefined()
2022-01-23 01:37:43 +01:00
Archi
1809028c77
Rider cleanup
2022-01-06 20:22:38 +01:00
Archi
e68210cf2e
Implement 2 additional crypto methods for Steam password
...
Inspiration by @legendofmiracles
2021-11-23 21:50:33 +01:00
Archi
ff8074aeb6
Use simplified hashing functions
2021-11-11 00:41:38 +01:00
Archi
d1e8794fe3
I won
2021-11-10 22:05:08 +01:00
Archi
258ad17930
Apply Rider inspections
...
Want to bet at least one will break netf?
2021-11-10 21:54:15 +01:00
Archi
1e6ab11d9f
Use file-scoped namespaces
2021-11-10 21:23:24 +01:00
Archi
0964cdac96
Minimize define hell
...
Skipping a 20 KB stub in OS-specific non-windows builds and omitting a few very fast if checks isn't worth the code quality degradation that involves all of the ifdef options.
ifdefs should be reserved for stuff that either doesn't compile whatsoever in some specific configurations (NETFRAMEWORK), or is required to make logical decisions based on the compiler input (e.g. DEBUG for detecting debugging builds or ASF_VARIANT_* for hardcoding the platform identifier to use for auto-updates)
In all other situations, we should use OperatingSystem if condition, even if it's equal to hitting them on the platforms that are unlikely to hit them.
And I say unlikely, because nothing stops me from downloading a win-x64 build and running it like a generic one on windows, what you gonna do?
2021-11-10 19:03:05 +01:00
Sebastian Göls
fb4eb0b03a
Use Madness via global usings ( #2447 )
...
* Use Madness via global usings
* Apply feedback
* Disable false positive null warning
2021-11-09 16:33:09 +01:00
Archi
14bab623b8
Actually be smarter
2021-10-14 00:25:41 +02:00
Archi
fc0c916137
Extend warnings for --cryptkey and lack of it
...
@Abrynos
2021-10-13 23:24:07 +02:00
Łukasz Domeradzki
965d3050a5
Address new Rider inspections (EAP) ( #2418 )
2021-10-01 01:21:09 +02:00
Archi
7e9e90764b
Use static lambdas wherever possible
...
Thanks Rider
2021-09-27 21:33:52 +02:00
Archi
f2d3a2a894
Use string interpolation wherever possible
...
Majority of cases still need to go through string.Format() due to localization requirements
2021-09-27 19:59:00 +02:00
Archi
dff549bd27
Misc
2021-08-13 23:34:44 +02:00
Łukasz Domeradzki
bb513921f1
Include ASF's windows-only parts only in generic and windows builds ( #2404 )
...
* Include ASF's windows-only parts only in generic and windows builds
* Apply Abry's note
2021-08-13 23:07:17 +02:00
Archi
de0ee3a497
Make use of latest Madness 1.1.0 features
2021-08-10 17:09:46 +02:00
Łukasz Domeradzki
9f281c6055
Embrace madness ( #2394 )
...
* Embrace madness
* Remove unused code
* Misc
* Address Abry's note
* Update for Madness 0.3.0
2021-08-07 14:03:46 +02:00
Archi
aa7fce300d
Use new OperatingSystem API for OS detection
...
Supporting netf gets harder every day...
2021-08-05 21:17:42 +02:00
Archi
d479eb9f97
Address Rider EAP inspections/cleanup
2021-07-12 21:45:17 +02:00
Archi
1a3b436216
Mis
2021-07-03 14:25:13 +02:00
Archi
d01a26e48a
OS: Add FreeBSD support inside ASF code
...
#2129
2021-06-21 11:47:20 +02:00
Archi
84d18874a2
Avoid saving the same content in SerializableFile calls
...
Normally this should not matter and it does not, but https://github.com/JustArchiNET/ASF-ui/pull/1409#issuecomment-855873098 highlighted a potential enhancement idea in which the caller requests ASF to save the same content as currently exists. Since write operation could emit unnecessary event which forces ASF to start/stop/restart bot/process, I believe that it's justified to add a read operation in front of it to ensure that the file actually needs to be written over.
2021-06-07 14:34:15 +02:00
JustArchi
bf89c005d7
Refactor a few bot config properties, add auto-migration
2021-05-08 22:00:25 +02:00
JustArchi
d21d2473fe
RuntimeCompatibility -> Compatibility
2021-05-08 01:43:08 +02:00
JustArchi
e60b54e402
Refactor EVERYTHING
...
Directories structure + namespaces relevant to them
2021-05-08 01:37:22 +02:00
JustArchi
daf37c723c
Document all the pragmas, final code corrections
2021-05-07 23:56:45 +02:00
JustArchi
90ff43dc98
Resolve CA1508
2021-05-07 16:49:02 +02:00
JustArchi
0e9b956ae9
Resolve CA1063
2021-05-06 23:45:10 +02:00
JustArchi
aed11c59ee
Cleanup round
2021-05-06 20:44:17 +02:00
JustArchi
fc16e7b29a
Misc
2021-01-14 20:05:43 +01:00
JustArchi
45a5fec95a
Happy 2021
...
And let's hope it'll be better than 2020
2021-01-03 22:24:22 +01:00
Vitaliy
4bc2c3ecd8
Fix interface members visibility ( #2094 )
2020-12-22 09:49:19 +01:00
JustArchi
34c5f5cf8b
Closes #2012
2020-12-18 22:06:15 +01:00
JustArchi
f66d5e6116
Remove unneeded restriction
2020-12-04 20:05:45 +01:00
JustArchi
8ff0ea1bb5
Misc
2020-11-29 16:18:40 +01:00
JustArchi
ba702a1dae
Misc
2020-11-28 23:18:23 +01:00
JustArchi
8fb91fe58b
Misc
2020-11-28 22:06:54 +01:00
JustArchi
d890a6b345
Misc
...
No reason for ICrossProcessSemaphore to be IDisposable
2020-11-16 00:52:43 +01:00
JustArchi
e82560259b
Final code cleanup
2020-11-14 22:37:00 +01:00
JustArchi
60ae4977da
Initial code cleanup
2020-11-11 16:51:31 +01:00
Łukasz Domeradzki
35f4651ed6
.NET 5.0 ( #1999 )
...
* Initial work
* Fix CIs
* Fix warnings
* Update .travis.yml
* Update dockerfiles
* Update libraries to .NET 5.0
* Misc
* Remove workaround for #1812
* Update cc.sh
* CI updates
* CI updates
* Update .travis.yml
2020-11-10 23:22:57 +01:00
JustArchi
b3d476dea4
Round 2 of nullable checks
2020-08-23 20:45:24 +02:00
Łukasz Domeradzki
9fc1ea65a5
Closes #1543 ( #1944 )
...
* Start working on nullable checks
help me
* Update GlobalConfig.cs
* Finish initial fixup round
* nullability code review
2020-08-22 21:41:01 +02:00
JustArchi
2cab6c82e4
Closes #1849
2020-06-16 10:04:51 +02:00
JustArchi
54a20246db
Use CrossProcessFileBasedSemaphore exclusively
...
Our reference implementation actually doesn't release the wait handle on process exit, which defeats the purpose. Use file-based semaphore on all OSes as it works reliably.
2020-06-15 23:28:52 +02:00
JustArchi
fe71dc8a99
Remove one finally too much
2020-05-22 10:45:48 +02:00
