Akatsuki-Misaki/ArchiSteamFarm
1
0
Fork 0
mirror of https://github.com/JustArchiNET/ArchiSteamFarm.git synced 2026-01-01 14:10:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use CrossProcessFileBasedSemaphore exclusively

Browse Source 
Our reference implementation actually doesn't release the wait handle on process exit, which defeats the purpose. Use file-based semaphore on all OSes as it works reliably.
This commit is contained in:
JustArchi
2020-06-15 23:28:52 +02:00
parent 822bfc239f
commit 54a20246db
2 changed files with 1 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
ArchiSteamFarm/Helpers/CrossProcessSemaphore.cs
View File

@@ -1,53 +0,0 @@
// _ _ _ ____ _ _____
// / \ _ __ ___ | |__ (_)/ ___| | |_ ___ __ _ _ __ ___ | ___|__ _ _ __ _ __ ___
// / _ \ | '__|/ __|| '_ \ | |\___ \ | __|/ _ \ / _` || '_ ` _ \ | |_ / _` || '__|| '_ ` _ \
// / ___ \ | | | (__ | | | || | ___) || |_| __/| (_| || | | | | || _|| (_| || | | | | | | |
// /_/ \_\|_| \___||_| |_||_||____/ \__|\___| \__,_||_| |_| |_||_| \__,_||_| |_| |_| |_|
// |
// Copyright 2015-2020 Łukasz "JustArchi" Domeradzki
// Contact: JustArchi@JustArchi.net
// |
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
// |
// http://www.apache.org/licenses/LICENSE-2.0
// |
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
using System;
using System.Threading;
using System.Threading.Tasks;
using JetBrains.Annotations;
namespace ArchiSteamFarm.Helpers {
internal sealed class CrossProcessSemaphore : ICrossProcessSemaphore {
private readonly Semaphore GlobalSemaphore;
internal CrossProcessSemaphore([NotNull] string name) {
if (string.IsNullOrEmpty(name)) {
throw new ArgumentNullException(nameof(name));
}
GlobalSemaphore = new Semaphore(1, 1, name);
}
public void Dispose() => GlobalSemaphore.Dispose();
void ICrossProcessSemaphore.Release() => GlobalSemaphore.Release();
[NotNull]
Task ICrossProcessSemaphore.WaitAsync() {
GlobalSemaphore.WaitOne();
return Task.CompletedTask;
}
[NotNull]
Task<bool> ICrossProcessSemaphore.WaitAsync(int millisecondsTimeout) => Task.FromResult(GlobalSemaphore.WaitOne(millisecondsTimeout));
}
}

9
ArchiSteamFarm/OS.cs
View File

@@ -71,14 +71,7 @@ namespace ArchiSteamFarm {
string resourceName = GetOsResourceName(objectName);
try {
return new CrossProcessSemaphore(resourceName);
} catch (PlatformNotSupportedException e) {
// CrossProcessSemaphore is currently available only for Windows platforms, we use alternative synchronization for other OSes
ASF.ArchiLogger.LogGenericDebuggingException(e);
return new CrossProcessFileBasedSemaphore(resourceName);
}
return new CrossProcessFileBasedSemaphore(resourceName);
}
internal static void Init(bool systemRequired, GlobalConfig.EOptimizationMode optimizationMode) {