Akatsuki-Misaki/ArchiSteamFarm
1
0
Fork 0
mirror of https://github.com/JustArchiNET/ArchiSteamFarm.git synced 2026-01-01 14:10:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't stack threads in OnHeartBeat()

Browse Source 
OnHeartBeat() is the least important function that is called every minute if required, not being able to enter the semaphore means some other action is already in progress, and while it makes sense for stuff like OnPersonaState() to wait for it, because it requires that, heartbeat can totally miss being executed, especially if the previous call didn't manage to finish yet.

It's not destructive as it is right now because tasks would be cancelled eventually when the server starts responding (due to if being removed right now), but it's entirely unnecessary burden.
This commit is contained in:
Archi
2021-10-13 10:38:14 +02:00
parent 0ff0fa8d95
commit 9b8050e2b3
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ArchiSteamFarm/Core/Statistics.cs
View File

@@ -105,13 +105,11 @@ namespace ArchiSteamFarm.Core {
return;
}
await RequestsSemaphore.WaitAsync().ConfigureAwait(false);
if (!await RequestsSemaphore.WaitAsync(0).ConfigureAwait(false)) {
return;
}
try {
if (!ShouldSendHeartBeats || (DateTime.UtcNow < LastHeartBeat.AddMinutes(MinHeartBeatTTL))) {
return;
}
Uri request = new($"{URL}/Api/HeartBeat");
Dictionary<string, string> data = new(2, StringComparer.Ordinal) {