Final Rider inspections

This commit is contained in:
Archi
2022-12-15 19:23:46 +01:00
parent c9cae6e258
commit fc20b6cfc4
12 changed files with 35 additions and 22 deletions

View File

@@ -345,11 +345,16 @@ public sealed class WebBrowser : IDisposable {
try {
using StreamReader streamReader = new(response.Content);
using JsonTextReader jsonReader = new(streamReader);
JsonSerializer serializer = new();
#pragma warning disable CA2000 // False positive, we're actually wrapping it in the using clause below exactly for that purpose
JsonTextReader jsonReader = new(streamReader);
#pragma warning restore CA2000 // False positive, we're actually wrapping it in the using clause below exactly for that purpose
obj = serializer.Deserialize<T>(jsonReader);
await using (jsonReader.ConfigureAwait(false)) {
JsonSerializer serializer = new();
obj = serializer.Deserialize<T>(jsonReader);
}
} catch (Exception e) {
if ((requestOptions.HasFlag(ERequestOptions.AllowInvalidBodyOnSuccess) && response.StatusCode.IsSuccessCode()) || (requestOptions.HasFlag(ERequestOptions.AllowInvalidBodyOnErrors) && !response.StatusCode.IsSuccessCode())) {
return new ObjectResponse<T>(response);
@@ -649,11 +654,16 @@ public sealed class WebBrowser : IDisposable {
try {
using StreamReader streamReader = new(response.Content);
using JsonReader jsonReader = new JsonTextReader(streamReader);
JsonSerializer serializer = new();
#pragma warning disable CA2000 // False positive, we're actually wrapping it in the using clause below exactly for that purpose
JsonReader jsonReader = new JsonTextReader(streamReader);
#pragma warning restore CA2000 // False positive, we're actually wrapping it in the using clause below exactly for that purpose
obj = serializer.Deserialize<TResult>(jsonReader);
await using (jsonReader.ConfigureAwait(false)) {
JsonSerializer serializer = new();
obj = serializer.Deserialize<TResult>(jsonReader);
}
} catch (Exception e) {
if ((requestOptions.HasFlag(ERequestOptions.AllowInvalidBodyOnSuccess) && response.StatusCode.IsSuccessCode()) || (requestOptions.HasFlag(ERequestOptions.AllowInvalidBodyOnErrors) && !response.StatusCode.IsSuccessCode())) {
return new ObjectResponse<TResult>(response);