Akatsuki-Misaki/ArchiSteamFarm
1
0
Fork 0
mirror of https://github.com/JustArchiNET/ArchiSteamFarm.git synced 2026-01-16 08:25:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Implement basic crash protection

Browse Source 
- On start, we create/load crash file, if previous startup was less than 5 minutes ago, we also increase the counter
- If counter reaches 5, we abort the process, that is, freeze the process by not loading anything other than auto-updates
- In order for user to recover from above, he needs to manually remove ASF.crash file
- If process exits normally without reaching counter of 5 yet, we remove crash file (reset the counter), normal exit includes SIGTERM, SIGINT, clicking [X], !exit, !restart, and anything else that allows ASF to gracefully quit
- If process exits abnormally, that includes SIGKILL, unhandled exceptions, as well as power outages and anything that prevents ASF from graceful quit, we keep crash file around
- Update procedure, as an exception, allows crash file removal even with counter of 5. This should allow crash file recovery for people that crashed before, without a need of manual removal.
This commit is contained in:
Archi
2024-02-03 21:18:47 +01:00
parent eb71b640c5
commit f0ef4c6ba6
7 changed files with 199 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
ArchiSteamFarm/Program.cs
View File

@@ -47,6 +47,7 @@ using SteamKit2;
namespace ArchiSteamFarm;
internal static class Program {
internal static bool AllowCrashFileRemoval { get; set; }
internal static bool ConfigMigrate { get; private set; } = true;
internal static bool ConfigWatch { get; private set; } = true;
internal static bool IgnoreUnsupportedEnvironment { get; private set; }
@@ -67,7 +68,7 @@ internal static class Program {
internal static async Task Exit(byte exitCode = 0) {
if (exitCode != 0) {
ASF.ArchiLogger.LogGenericError(Strings.ErrorExitingWithNonZeroErrorCode);
ASF.ArchiLogger.LogGenericError(string.Format(CultureInfo.CurrentCulture, Strings.ErrorExitingWithNonZeroErrorCode, exitCode));
}
await Shutdown(exitCode).ConfigureAwait(false);
@@ -444,7 +445,7 @@ internal static class Program {
return true;
}
private static async Task<bool> InitShutdownSequence() {
private static async Task<bool> InitShutdownSequence(byte exitCode = 0) {
if (ShutdownSequenceInitialized) {
// We've already initialized shutdown sequence before, we won't allow the caller to init shutdown sequence again
// While normally this will be respected, caller might not have any say in this for example because it's the runtime terminating ASF due to fatal exception
@@ -456,8 +457,8 @@ internal static class Program {
ShutdownSequenceInitialized = true;
// Unregister from registered signals
if (OperatingSystem.IsFreeBSD() || OperatingSystem.IsLinux() || OperatingSystem.IsMacOS()) {
// Unregister from registered signals
foreach (PosixSignalRegistration registration in RegisteredPosixSignals.Values) {
registration.Dispose();
}
@@ -465,6 +466,19 @@ internal static class Program {
RegisteredPosixSignals.Clear();
}
// Remove crash file if allowed
if ((exitCode == 0) && AllowCrashFileRemoval) {
string crashFile = ASF.GetFilePath(ASF.EFileType.Crash);
if (File.Exists(crashFile)) {
try {
File.Delete(crashFile);
} catch (Exception e) {
ASF.ArchiLogger.LogGenericException(e);
}
}
}
// Sockets created by IPC might still be running for a short while after complete app shutdown
// Ensure that IPC is stopped before we finalize shutdown sequence
await ArchiKestrel.Stop().ConfigureAwait(false);
@@ -497,16 +511,13 @@ internal static class Program {
return await ShutdownResetEvent.Task.ConfigureAwait(false);
}
private static async void OnCancelKeyPress(object? sender, ConsoleCancelEventArgs e) => await Exit(130).ConfigureAwait(false);
private static async void OnCancelKeyPress(object? sender, ConsoleCancelEventArgs e) => await Exit().ConfigureAwait(false);
private static async void OnPosixSignal(PosixSignalContext signal) {
ArgumentNullException.ThrowIfNull(signal);
switch (signal.Signal) {
case PosixSignal.SIGINT:
await Exit(130).ConfigureAwait(false);
break;
case PosixSignal.SIGTERM:
await Exit().ConfigureAwait(false);
@@ -704,7 +715,7 @@ internal static class Program {
}
private static async Task Shutdown(byte exitCode = 0) {
if (!await InitShutdownSequence().ConfigureAwait(false)) {
if (!await InitShutdownSequence(exitCode).ConfigureAwait(false)) {
return;
}