From c2ea04c8897a30703a4b89f06edaf5064ebd8a6c Mon Sep 17 00:00:00 2001
From: JustArchi <JustArchi@JustArchi.net>
Date: Fri, 18 Sep 2020 00:51:29 +0200
Subject: [PATCH] Correct logic on 4xx and 5xx

4xx should never be retried, 5xx should be retried if we're not returning the error.
---
 ArchiSteamFarm/WebBrowser.cs | 40 ++++++++++++++++++------------------
 1 file changed, 20 insertions(+), 20 deletions(-)

diff --git a/ArchiSteamFarm/WebBrowser.cs b/ArchiSteamFarm/WebBrowser.cs
index 9553a5835..1f6a0408e 100644
--- a/ArchiSteamFarm/WebBrowser.cs
+++ b/ArchiSteamFarm/WebBrowser.cs
@@ -127,8 +127,8 @@ namespace ArchiSteamFarm {
 
 				if (response.StatusCode.IsClientErrorCode()) {
 					if (!requestOptions.HasFlag(ERequestOptions.ReturnClientErrors)) {
-						// We're not handling this error, try again
-						continue;
+						// We're not handling this error, do not try again
+						break;
 					}
 
 					handleError = true;
@@ -227,8 +227,8 @@ namespace ArchiSteamFarm {
 
 				if (response.StatusCode.IsClientErrorCode()) {
 					if (!requestOptions.HasFlag(ERequestOptions.ReturnClientErrors)) {
-						// We're not handling this error, try again
-						continue;
+						// We're not handling this error, do not try again
+						break;
 					}
 
 					handleError = true;
@@ -290,8 +290,8 @@ namespace ArchiSteamFarm {
 
 				if (response.StatusCode.IsClientErrorCode()) {
 					if (!requestOptions.HasFlag(ERequestOptions.ReturnClientErrors)) {
-						// We're not handling this error, try again
-						continue;
+						// We're not handling this error, do not try again
+						break;
 					}
 
 					handleError = true;
@@ -365,8 +365,8 @@ namespace ArchiSteamFarm {
 
 				if (response.StatusCode.IsClientErrorCode()) {
 					if (!requestOptions.HasFlag(ERequestOptions.ReturnClientErrors)) {
-						// We're not handling this error, try again
-						continue;
+						// We're not handling this error, do not try again
+						break;
 					}
 
 					handleError = true;
@@ -420,8 +420,8 @@ namespace ArchiSteamFarm {
 
 				if (response.StatusCode.IsClientErrorCode()) {
 					if (!requestOptions.HasFlag(ERequestOptions.ReturnClientErrors)) {
-						// We're not handling this error, try again
-						continue;
+						// We're not handling this error, do not try again
+						break;
 					}
 
 					handleError = true;
@@ -475,8 +475,8 @@ namespace ArchiSteamFarm {
 
 				if (response.StatusCode.IsClientErrorCode()) {
 					if (!requestOptions.HasFlag(ERequestOptions.ReturnClientErrors)) {
-						// We're not handling this error, try again
-						continue;
+						// We're not handling this error, do not try again
+						break;
 					}
 
 					handleError = true;
@@ -548,7 +548,7 @@ namespace ArchiSteamFarm {
 						result = new BasicResponse(response);
 					}
 
-					break;
+					continue;
 				}
 
 				return new BasicResponse(response);
@@ -590,7 +590,7 @@ namespace ArchiSteamFarm {
 						result = new BasicResponse(response);
 					}
 
-					break;
+					continue;
 				}
 
 				return new BasicResponse(response);
@@ -624,8 +624,8 @@ namespace ArchiSteamFarm {
 
 				if (response.StatusCode.IsClientErrorCode()) {
 					if (!requestOptions.HasFlag(ERequestOptions.ReturnClientErrors)) {
-						// We're not handling this error, try again
-						continue;
+						// We're not handling this error, do not try again
+						break;
 					}
 
 					handleError = true;
@@ -687,8 +687,8 @@ namespace ArchiSteamFarm {
 
 				if (response.StatusCode.IsClientErrorCode()) {
 					if (!requestOptions.HasFlag(ERequestOptions.ReturnClientErrors)) {
-						// We're not handling this error, try again
-						continue;
+						// We're not handling this error, do not try again
+						break;
 					}
 
 					handleError = true;
@@ -762,8 +762,8 @@ namespace ArchiSteamFarm {
 
 				if (response.StatusCode.IsClientErrorCode()) {
 					if (!requestOptions.HasFlag(ERequestOptions.ReturnClientErrors)) {
-						// We're not handling this error, try again
-						continue;
+						// We're not handling this error, do not try again
+						break;
 					}
 
 					handleError = true;