Akatsuki-Misaki/ArchiSteamFarm
1
0
Fork 0
mirror of https://github.com/JustArchiNET/ArchiSteamFarm.git synced 2026-01-16 08:25:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Implement additional checksum verification for ASF builds (#2453)

Browse Source 
* #2452

* Fix netf

* Apply feedback

* Misc

* Misc

* Apply feedback
This commit is contained in:
Łukasz Domeradzki
2021-11-18 21:16:47 +01:00
committed by GitHub
parent b7aee818b4
commit 99569ee3fe
8 changed files with 352 additions and 177 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
ArchiSteamFarm/Core/ASF.cs
View File

@@ -285,6 +285,31 @@ public static class ASF {
return null;
}
ArchiLogger.LogGenericInfo(Strings.VerifyingChecksumWithRemoteServer);
string? remoteChecksum = await ArchiNet.FetchBuildChecksum(newVersion, SharedInfo.BuildInfo.Variant).ConfigureAwait(false);
switch (remoteChecksum) {
case null:
// Timeout or error, refuse to update as a security measure
return null;
case "":
// Unknown checksum, release too new or actual malicious build published, no need to scare the user as it's 99.99% the first
ArchiLogger.LogGenericWarning(Strings.ChecksumMissing);
return SharedInfo.Version;
}
byte[] responseBytes = response.Content as byte[] ?? response.Content.ToArray();
string checksum = BitConverter.ToString(SHA512.HashData(responseBytes)).Replace("-", "", StringComparison.Ordinal);
if (!checksum.Equals(remoteChecksum, StringComparison.OrdinalIgnoreCase)) {
ArchiLogger.LogGenericError(Strings.ChecksumWrong);
return SharedInfo.Version;
}
try {
// We disable ArchiKestrel here as the update process moves the core files and might result in IPC crash
// TODO: It might fail if the update was triggered from the API, this should be something to improve in the future, by changing the structure into request -> return response -> finish update
@@ -293,7 +318,9 @@ public static class ASF {
ArchiLogger.LogGenericWarningException(e);
}
MemoryStream ms = new(response.Content as byte[] ?? response.Content.ToArray());
ArchiLogger.LogGenericInfo(Strings.PatchingFiles);
MemoryStream ms = new(responseBytes);
try {
await using (ms.ConfigureAwait(false)) {