Code review

ConfigGenerator/ASFConfig.cs

@@ -29,7 +29,7 @@ using System.IO;
 
 namespace ConfigGenerator {
 	internal class ASFConfig {
-		internal static HashSet<ASFConfig> ASFConfigs = new HashSet<ASFConfig>();
+		internal static readonly HashSet<ASFConfig> ASFConfigs = new HashSet<ASFConfig>();
 
 		internal string FilePath { get; set; }
 

ConfigGenerator/BotConfig.cs

@@ -119,7 +119,7 @@ namespace ConfigGenerator {
 		}
 
 		// This constructor is used only by deserializer
-		private BotConfig() : base() { }
+		private BotConfig() { }
 
 		private BotConfig(string filePath) : base(filePath) {
 			FilePath = filePath;

ConfigGenerator/ConfigGenerator.csproj

@@ -44,14 +44,8 @@
     </Reference>
     <Reference Include="System" />
     <Reference Include="System.Core" />
-    <Reference Include="System.Xml.Linq" />
-    <Reference Include="System.Data.DataSetExtensions" />
-    <Reference Include="Microsoft.CSharp" />
-    <Reference Include="System.Data" />
     <Reference Include="System.Drawing" />
-    <Reference Include="System.Net.Http" />
     <Reference Include="System.Windows.Forms" />
-    <Reference Include="System.Xml" />
   </ItemGroup>
   <ItemGroup>
     <Compile Include="ASFConfig.cs" />

ConfigGenerator/ConfigPage.cs

@@ -27,12 +27,9 @@ using System.Windows.Forms;
 
 namespace ConfigGenerator {
 	internal class ConfigPage : TabPage {
-
 		internal readonly ASFConfig ASFConfig;
 
-		private EnhancedPropertyGrid EnhancedPropertyGrid;
-
-		internal ConfigPage(ASFConfig config) : base() {
+		internal ConfigPage(ASFConfig config) {
 			if (config == null) {
 				return;
 			}
@@ -41,17 +38,12 @@ namespace ConfigGenerator {
 
 			RefreshText();
 
-			EnhancedPropertyGrid = new EnhancedPropertyGrid(config);
-			Controls.Add(EnhancedPropertyGrid);
+			EnhancedPropertyGrid enhancedPropertyGrid = new EnhancedPropertyGrid(config);
+			Controls.Add(enhancedPropertyGrid);
 		}
 
 		internal void RefreshText() {
 			Text = Path.GetFileNameWithoutExtension(ASFConfig.FilePath);
 		}
-
-		private void InitializeComponent() {
-			SuspendLayout();
-			ResumeLayout(false);
-		}
 	}
 }

ConfigGenerator/EnhancedPropertyGrid.cs

@@ -26,9 +26,9 @@ using System.Windows.Forms;
 
 namespace ConfigGenerator {
 	internal sealed class EnhancedPropertyGrid : PropertyGrid {
-		private ASFConfig ASFConfig;
+		private readonly ASFConfig ASFConfig;
 
-		internal EnhancedPropertyGrid(ASFConfig config) : base() {
+		internal EnhancedPropertyGrid(ASFConfig config) {
 			if (config == null) {
 				return;
 			}
@@ -66,7 +66,6 @@ namespace ConfigGenerator {
 				if (globalConfig.SteamOwnerID != 0) {
 					Tutorial.OnAction(Tutorial.EPhase.GlobalConfigReady);
 				}
-				return;
 			}
 		}
 	}

ConfigGenerator/GlobalConfig.cs

@@ -40,8 +40,7 @@ namespace ConfigGenerator {
 		private const byte DefaultFarmingDelay = 5;
 		private const byte DefaultHttpTimeout = 60;
 		private const ushort DefaultWCFPort = 1242;
-
-		private static readonly ProtocolType DefaultSteamProtocol = ProtocolType.Tcp;
+		private const ProtocolType DefaultSteamProtocol = ProtocolType.Tcp;
 
 		// This is hardcoded blacklist which should not be possible to change
 		internal static readonly HashSet<uint> GlobalBlacklist = new HashSet<uint> { 267420, 303700, 335590, 368020, 425280 };
@@ -161,7 +160,7 @@ namespace ConfigGenerator {
 		}
 
 		// This constructor is used only by deserializer
-		private GlobalConfig() : base() { }
+		private GlobalConfig() { }
 
 		private GlobalConfig(string filePath) : base(filePath) {
 			FilePath = filePath;

ConfigGenerator/MainForm.cs

@@ -23,6 +23,7 @@
 */
 
 using System;
+using System.ComponentModel;
 using System.Diagnostics;
 using System.IO;
 using System.Windows.Forms;
@@ -31,20 +32,11 @@ namespace ConfigGenerator {
 	public partial class MainForm : Form {
 		private const byte ReservedTabs = 3;
 
+		private readonly TabPage NewTab = new TabPage { Text = "+" };
+		private readonly TabPage RemoveTab = new TabPage { Text = "-" };
+		private readonly TabPage RenameTab = new TabPage { Text = "~" };
+
 		private ConfigPage ASFTab;
-
-		private TabPage RemoveTab = new TabPage() {
-			Text = "-",
-		};
-
-		private TabPage RenameTab = new TabPage() {
-			Text = "~",
-		};
-
-		private TabPage NewTab = new TabPage() {
-			Text = "+",
-		};
-
 		private TabPage OldTab;
 
 		public MainForm() {
@@ -73,7 +65,7 @@ namespace ConfigGenerator {
 				Tutorial.Enabled = false;
 			}
 
-			MainTab.TabPages.AddRange(new TabPage[] { RemoveTab, RenameTab, NewTab });
+			MainTab.TabPages.AddRange(new[] { RemoveTab, RenameTab, NewTab });
 			Tutorial.OnAction(Tutorial.EPhase.Start);
 		}
 
@@ -186,7 +178,7 @@ namespace ConfigGenerator {
 			Tutorial.OnAction(Tutorial.EPhase.Shown);
 		}
 
-		private void MainForm_HelpButtonClicked(object sender, System.ComponentModel.CancelEventArgs e) {
+		private void MainForm_HelpButtonClicked(object sender, CancelEventArgs e) {
 			if (sender == null || e == null) {
 				return;
 			}

ConfigGenerator/Program.cs

@@ -36,10 +36,7 @@ namespace ConfigGenerator {
 
 		private const string ASFDirectory = "ArchiSteamFarm";
 
-		private static readonly Assembly Assembly = Assembly.GetExecutingAssembly();
-		private static readonly string ExecutableFile = Assembly.Location;
-		private static readonly string ExecutableName = Path.GetFileName(ExecutableFile);
-		private static readonly string ExecutableDirectory = Path.GetDirectoryName(ExecutableFile);
+		private static readonly string ExecutableDirectory = Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location);
 
 		/// <summary>
 		/// The main entry point for the application.