From 4b7369661c80b4194b3eb60ddea675ffaaa4b47d Mon Sep 17 00:00:00 2001 From: JustArchi Date: Sat, 18 Apr 2020 14:12:45 +0200 Subject: [PATCH] Do not dispose WebBrowser.HtmlDocumentResponse We're disposing inner document already, and this can't be disposed too early --- ArchiSteamFarm/ArchiWebHandler.cs | 4 ++-- ArchiSteamFarm/WebBrowser.cs | 4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/ArchiSteamFarm/ArchiWebHandler.cs b/ArchiSteamFarm/ArchiWebHandler.cs index 15238eda9..a40a747e7 100644 --- a/ArchiSteamFarm/ArchiWebHandler.cs +++ b/ArchiSteamFarm/ArchiWebHandler.cs @@ -472,7 +472,7 @@ namespace ArchiSteamFarm { } } - using WebBrowser.HtmlDocumentResponse response = await WebLimitRequest(host, async () => await WebBrowser.UrlGetToHtmlDocument(host + request).ConfigureAwait(false)).ConfigureAwait(false); + WebBrowser.HtmlDocumentResponse response = await WebLimitRequest(host, async () => await WebBrowser.UrlGetToHtmlDocument(host + request).ConfigureAwait(false)).ConfigureAwait(false); if (response == null) { return null; @@ -809,7 +809,7 @@ namespace ArchiSteamFarm { } } - using WebBrowser.HtmlDocumentResponse response = await WebLimitRequest(host, async () => await WebBrowser.UrlPostToHtmlDocument(host + request, data, referer).ConfigureAwait(false)).ConfigureAwait(false); + WebBrowser.HtmlDocumentResponse response = await WebLimitRequest(host, async () => await WebBrowser.UrlPostToHtmlDocument(host + request, data, referer).ConfigureAwait(false)).ConfigureAwait(false); if (response == null) { return null; diff --git a/ArchiSteamFarm/WebBrowser.cs b/ArchiSteamFarm/WebBrowser.cs index 34aafb9e2..a64017d9c 100644 --- a/ArchiSteamFarm/WebBrowser.cs +++ b/ArchiSteamFarm/WebBrowser.cs @@ -813,7 +813,7 @@ namespace ArchiSteamFarm { } } - public sealed class HtmlDocumentResponse : BasicResponse, IDisposable { + public sealed class HtmlDocumentResponse : BasicResponse { [PublicAPI] public readonly IDocument Content; @@ -831,8 +831,6 @@ namespace ArchiSteamFarm { Content = document; } - public void Dispose() => Content?.Dispose(); - [ItemCanBeNull] internal static async Task Create([NotNull] StreamResponse streamResponse) { if (streamResponse == null) {