diff --git a/ArchiSteamFarm.Tests/IGitHubPluginUpdates.cs b/ArchiSteamFarm.Tests/IGitHubPluginUpdates.cs new file mode 100644 index 000000000..1ae52778f --- /dev/null +++ b/ArchiSteamFarm.Tests/IGitHubPluginUpdates.cs @@ -0,0 +1,83 @@ +// ---------------------------------------------------------------------------------------------- +// _ _ _ ____ _ _____ +// / \ _ __ ___ | |__ (_)/ ___| | |_ ___ __ _ _ __ ___ | ___|__ _ _ __ _ __ ___ +// / _ \ | '__|/ __|| '_ \ | |\___ \ | __|/ _ \ / _` || '_ ` _ \ | |_ / _` || '__|| '_ ` _ \ +// / ___ \ | | | (__ | | | || | ___) || |_| __/| (_| || | | | | || _|| (_| || | | | | | | | +// /_/ \_\|_| \___||_| |_||_||____/ \__|\___| \__,_||_| |_| |_||_| \__,_||_| |_| |_| |_| +// ---------------------------------------------------------------------------------------------- +// | +// Copyright 2015-2025 Ɓukasz "JustArchi" Domeradzki +// Contact: JustArchi@JustArchi.net +// | +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// | +// http://www.apache.org/licenses/LICENSE-2.0 +// | +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +using System; +using System.Threading.Tasks; +using ArchiSteamFarm.Core; +using ArchiSteamFarm.Localization; +using ArchiSteamFarm.NLog; +using ArchiSteamFarm.Storage; +using ArchiSteamFarm.Web; +using ArchiSteamFarm.Web.GitHub; +using ArchiSteamFarm.Web.GitHub.Data; +using Microsoft.VisualStudio.TestTools.UnitTesting; + +namespace ArchiSteamFarm.Tests; + +#pragma warning disable CA1812 // False positive, the class is used during MSTest +[TestClass] +internal sealed class IGitHubPluginUpdates { + private const string PluginName = "ArchiSteamFarm.OfficialPlugins.Monitoring"; + private const string Repository = "JustArchiNET/ArchiSteamFarm"; + + [Ignore("For manual testing only, since it calls remote resources")] + [TestMethod] + internal async Task DoesNotOfferPointlessUpdatesWhenMultipleAssetsAreFound() { + using WebBrowser webBrowser = new(new ArchiLogger("Test")); + + typeof(ASF).GetProperty(nameof(ASF.WebBrowser))?.SetValue(null, webBrowser); + + ReleaseResponse? response = await GitHubService.GetLatestRelease(Repository).ConfigureAwait(false); + + if (response == null) { + Assert.Inconclusive(Strings.FormatWarningFailedWithError(nameof(response))); + } + + Version version = Version.Parse(response.Tag); + + Plugins.Interfaces.IGitHubPluginUpdates plugin = new TestGitHubPluginUpdates(version); + + Uri? releaseURL = await plugin.GetTargetReleaseURL(version, BuildInfo.Variant, true, GlobalConfig.EUpdateChannel.Stable, false).ConfigureAwait(false); + + Assert.IsNull(releaseURL); + + Uri? forcedReleaseURL = await plugin.GetTargetReleaseURL(version, BuildInfo.Variant, true, GlobalConfig.EUpdateChannel.Stable, true).ConfigureAwait(false); + + Assert.IsNotNull(forcedReleaseURL); + } + + private sealed class TestGitHubPluginUpdates : Plugins.Interfaces.IGitHubPluginUpdates { + public string Name => PluginName; + public string RepositoryName => Repository; + public Version Version { get; } + + internal TestGitHubPluginUpdates(Version version) { + ArgumentNullException.ThrowIfNull(version); + + Version = version; + } + + public Task OnLoaded() => Task.CompletedTask; + } +} +#pragma warning restore CA1812 // False positive, the class is used during MSTest diff --git a/ArchiSteamFarm/Plugins/Interfaces/IGitHubPluginUpdates.cs b/ArchiSteamFarm/Plugins/Interfaces/IGitHubPluginUpdates.cs index a55a79807..05944ab06 100644 --- a/ArchiSteamFarm/Plugins/Interfaces/IGitHubPluginUpdates.cs +++ b/ArchiSteamFarm/Plugins/Interfaces/IGitHubPluginUpdates.cs @@ -181,7 +181,7 @@ public interface IGitHubPluginUpdates : IPluginUpdates { // Then calculate assets that can possibly take part in the update process, in order to determine whether the change of plugin variant is possible // The base condition is that the release must have at least 2 total assets, therefore we need to only take into account GetPossibleMatchesByName() logic, while assuming that version is flexible // If by the end we have at least 2 assets we're considering for an update, then that's a possible variant change and in this case we should proceed to cover for the edge case explained above - if ((Version > newVersion) || !asfUpdate || (releaseResponse.Assets.Count < 2) || (GetPossibleNames().Sum(pluginName => releaseResponse.Assets.Count(asset => asset.Name.Equals($"{pluginName}.zip", StringComparison.OrdinalIgnoreCase) || (asset.Name.StartsWith($"{pluginName}-V", StringComparison.OrdinalIgnoreCase) && asset.Name.EndsWith(".zip", StringComparison.OrdinalIgnoreCase)))) < 2)) { + if ((Version > newVersion) || !asfUpdate || (releaseResponse.Assets.Count < 2) || GetPossibleNames().All(pluginName => releaseResponse.Assets.Count(asset => asset.Name.Equals($"{pluginName}.zip", StringComparison.OrdinalIgnoreCase) || (asset.Name.StartsWith($"{pluginName}-V", StringComparison.OrdinalIgnoreCase) && asset.Name.EndsWith(".zip", StringComparison.OrdinalIgnoreCase))) < 2)) { ASF.ArchiLogger.LogGenericInfo(Strings.FormatPluginUpdateNotFound(Name, Version, newVersion)); return null;