Closes #2500 (#2501)

* Start work on #2500

* Update Bot.cs

* Misc refactor

* Update Bot.cs

* Add fallback for older plugins

* Misc

* Apply feedback

ArchiSteamFarm/Plugins/Interfaces/IBotCommand.cs

@@ -19,6 +19,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+using System;
 using System.Threading.Tasks;
 using ArchiSteamFarm.Steam;
 using ArchiSteamFarm.Storage;
@@ -27,6 +28,7 @@ using JetBrains.Annotations;
 namespace ArchiSteamFarm.Plugins.Interfaces;
 
 [PublicAPI]
+[Obsolete($"Use {nameof(IBotCommand2)} instead, this one will be removed soon.", true)]
 public interface IBotCommand : IPlugin {
 	/// <summary>
 	///     ASF will call this method for unrecognized commands.

ArchiSteamFarm/Plugins/Interfaces/IBotCommand2.cs

@@ -0,0 +1,41 @@
+//     _                _      _  ____   _                           _____
+//    / \    _ __  ___ | |__  (_)/ ___| | |_  ___   __ _  _ __ ___  |  ___|__ _  _ __  _ __ ___
+//   / _ \  | '__|/ __|| '_ \ | |\___ \ | __|/ _ \ / _` || '_ ` _ \ | |_  / _` || '__|| '_ ` _ \
+//  / ___ \ | |  | (__ | | | || | ___) || |_|  __/| (_| || | | | | ||  _|| (_| || |   | | | | | |
+// /_/   \_\|_|   \___||_| |_||_||____/  \__|\___| \__,_||_| |_| |_||_|   \__,_||_|   |_| |_| |_|
+// |
+// Copyright 2015-2022 Łukasz "JustArchi" Domeradzki
+// Contact: JustArchi@JustArchi.net
+// |
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// |
+// http://www.apache.org/licenses/LICENSE-2.0
+// |
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+using System.Threading.Tasks;
+using ArchiSteamFarm.Steam;
+using ArchiSteamFarm.Storage;
+using JetBrains.Annotations;
+
+namespace ArchiSteamFarm.Plugins.Interfaces;
+
+[PublicAPI]
+public interface IBotCommand2 : IPlugin {
+	/// <summary>
+	///     ASF will call this method for unrecognized commands.
+	/// </summary>
+	/// <param name="bot">Bot object related to this callback.</param>
+	/// <param name="access">Access of user executing the command.</param>
+	/// <param name="message">Command message in its raw format, stripped of <see cref="GlobalConfig.CommandPrefix" />.</param>
+	/// <param name="args">Pre-parsed message using standard ASF delimiters.</param>
+	/// <param name="steamID">Optionally, steamID of the user who executed the command - may not be available with value of 0 (e.g. ASF API).</param>
+	/// <returns>Response to the command, or null/empty (as the task value) if the command isn't handled by this plugin.</returns>
+	Task<string?> OnBotCommand(Bot bot, EAccess access, string message, string[] args, ulong steamID = 0);
+}

ArchiSteamFarm/Plugins/PluginsCore.cs

@@ -22,6 +22,7 @@
 using System;
 using System.Collections.Generic;
 using System.Collections.Immutable;
+using System.ComponentModel;
 using System.Composition;
 using System.Composition.Convention;
 using System.Composition.Hosting;
@@ -39,6 +40,7 @@ using ArchiSteamFarm.Steam;
 using ArchiSteamFarm.Steam.Data;
 using ArchiSteamFarm.Steam.Exchange;
 using ArchiSteamFarm.Steam.Integration.Callbacks;
+using ArchiSteamFarm.Storage;
 using Newtonsoft.Json.Linq;
 using SteamKit2;
 
@@ -266,11 +268,11 @@ internal static class PluginsCore {
 		}
 	}
 
-	internal static async Task<string?> OnBotCommand(Bot bot, ulong steamID, string message, string[] args) {
+	internal static async Task<string?> OnBotCommand(Bot bot, EAccess access, string message, string[] args, ulong steamID = 0) {
 		ArgumentNullException.ThrowIfNull(bot);
 
-		if ((steamID == 0) || !new SteamID(steamID).IsIndividualAccount) {
-			throw new ArgumentOutOfRangeException(nameof(steamID));
+		if (!Enum.IsDefined(typeof(EAccess), access)) {
+			throw new InvalidEnumArgumentException(nameof(access), (int) access, typeof(EAccess));
 		}
 
 		if (string.IsNullOrEmpty(message)) {
@@ -288,13 +290,37 @@ internal static class PluginsCore {
 		IList<string?> responses;
 
 		try {
-			responses = await Utilities.InParallel(ActivePlugins.OfType<IBotCommand>().Select(plugin => plugin.OnBotCommand(bot, steamID, message, args))).ConfigureAwait(false);
+			responses = await Utilities.InParallel(ActivePlugins.OfType<IBotCommand2>().Select(plugin => plugin.OnBotCommand(bot, access, message, args, steamID))).ConfigureAwait(false);
 		} catch (Exception e) {
 			ASF.ArchiLogger.LogGenericException(e);
 
 			return null;
 		}
 
+		ulong oldSteamID = steamID;
+
+		if (oldSteamID == 0) {
+			oldSteamID = ASF.GlobalConfig?.SteamOwnerID ?? GlobalConfig.DefaultSteamOwnerID;
+		}
+
+		if ((oldSteamID != 0) && new SteamID(oldSteamID).IsIndividualAccount) {
+			IList<string?> oldResponses;
+
+			try {
+#pragma warning disable CS0618 // We intentionally support deprecated interface for a while longer
+				oldResponses = await Utilities.InParallel(ActivePlugins.OfType<IBotCommand>().Select(plugin => plugin.OnBotCommand(bot, oldSteamID, message, args))).ConfigureAwait(false);
+#pragma warning restore CS0618 // We intentionally support deprecated interface for a while longer
+			} catch (Exception e) {
+				ASF.ArchiLogger.LogGenericException(e);
+
+				return null;
+			}
+
+			foreach (string? oldResponse in oldResponses) {
+				responses.Add(oldResponse);
+			}
+		}
+
 		return string.Join(Environment.NewLine, responses.Where(static response => !string.IsNullOrEmpty(response)));
 	}