From 1fe628bd5d2e146ad0e50839de8031217302a660 Mon Sep 17 00:00:00 2001 From: JustArchi Date: Fri, 21 Oct 2016 21:39:58 +0200 Subject: [PATCH] Code review --- ArchiSteamFarm/Trading.cs | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/ArchiSteamFarm/Trading.cs b/ArchiSteamFarm/Trading.cs index 15e12c153..451a9a3ef 100644 --- a/ArchiSteamFarm/Trading.cs +++ b/ArchiSteamFarm/Trading.cs @@ -188,13 +188,18 @@ namespace ArchiSteamFarm { // Check if it's donation trade if (tradeOffer.ItemsToGive.Count == 0) { - // Temporarily ignore steam fuckups + ParseTradeResult.EResult donationResult; + + // If it's steam fuckup, temporarily ignore it, otherwise react accordingly, depending on our preference if (tradeOffer.ItemsToReceive.Count == 0) { - return new ParseTradeResult(tradeOffer.TradeOfferID, ParseTradeResult.EResult.RejectedTemporarily); + donationResult = ParseTradeResult.EResult.RejectedTemporarily; + } else if (Bot.BotConfig.TradingPreferences.HasFlag(BotConfig.ETradingPreferences.AcceptDonations)) { + donationResult = ParseTradeResult.EResult.AcceptedWithoutItemLose; + } else { + donationResult = ParseTradeResult.EResult.RejectedPermanently; } - // Either accept or reject such trade, depending on our preference - return Bot.BotConfig.TradingPreferences.HasFlag(BotConfig.ETradingPreferences.AcceptDonations) ? new ParseTradeResult(tradeOffer.TradeOfferID, ParseTradeResult.EResult.AcceptedWithoutItemLose) : new ParseTradeResult(tradeOffer.TradeOfferID, ParseTradeResult.EResult.RejectedPermanently); + return new ParseTradeResult(tradeOffer.TradeOfferID, donationResult); } // Always accept trades from SteamMasterID