From 10ffd242cd5c63639f2acf8035b0e00343e4a1bf Mon Sep 17 00:00:00 2001 From: JustArchi Date: Thu, 21 Sep 2017 03:16:42 +0200 Subject: [PATCH] ReSharper ignored warnings review --- ArchiSteamFarm/ArchiHandler.cs | 1 + ArchiSteamFarm/ArchiLogger.cs | 2 -- ArchiSteamFarm/Bot.cs | 2 -- ArchiSteamFarm/BotConfig.cs | 3 --- ArchiSteamFarm/BotDatabase.cs | 2 -- ArchiSteamFarm/CardsFarmer.cs | 1 - ArchiSteamFarm/GlobalConfig.cs | 6 ++---- ArchiSteamFarm/JSON/GitHub.cs | 1 - ArchiSteamFarm/JSON/Steam.cs | 11 ----------- ArchiSteamFarm/MobileAuthenticator.cs | 3 --- ArchiSteamFarm/Utilities.cs | 2 +- 11 files changed, 4 insertions(+), 30 deletions(-) diff --git a/ArchiSteamFarm/ArchiHandler.cs b/ArchiSteamFarm/ArchiHandler.cs index 4ef20e894..4eec2302f 100644 --- a/ArchiSteamFarm/ArchiHandler.cs +++ b/ArchiSteamFarm/ArchiHandler.cs @@ -286,6 +286,7 @@ namespace ArchiSteamFarm { internal enum ENotification : byte { [SuppressMessage("ReSharper", "UnusedMember.Global")] Unknown = 0, + Trading = 1, // Only custom below, different than ones available as user_notification_type diff --git a/ArchiSteamFarm/ArchiLogger.cs b/ArchiSteamFarm/ArchiLogger.cs index ef4a9576f..7e45a140c 100644 --- a/ArchiSteamFarm/ArchiLogger.cs +++ b/ArchiSteamFarm/ArchiLogger.cs @@ -23,7 +23,6 @@ */ using System; -using System.Diagnostics.CodeAnalysis; using System.IO; using System.Runtime.CompilerServices; using ArchiSteamFarm.Localization; @@ -140,7 +139,6 @@ namespace ArchiSteamFarm { Logger.Warn(exception, $"{previousMethodName}()"); } - [SuppressMessage("ReSharper", "ExplicitCallerInfoArgument")] internal void LogNullError(string nullObjectName, [CallerMemberName] string previousMethodName = null) { if (string.IsNullOrEmpty(nullObjectName)) { return; diff --git a/ArchiSteamFarm/Bot.cs b/ArchiSteamFarm/Bot.cs index 1f049efe7..2c14fefde 100755 --- a/ArchiSteamFarm/Bot.cs +++ b/ArchiSteamFarm/Bot.cs @@ -332,7 +332,6 @@ namespace ArchiSteamFarm { if (packageIDs.Count > 0) { DateTime mostRecent = DateTime.MinValue; - // ReSharper disable once LoopCanBePartlyConvertedToQuery - C# 7.0 out can't be used within LINQ query yet | https://github.com/dotnet/roslyn/issues/15619 foreach (uint packageID in packageIDs) { if (!OwnedPackageIDs.TryGetValue(packageID, out (EPaymentMethod PaymentMethod, DateTime TimeCreated) packageData)) { continue; @@ -365,7 +364,6 @@ namespace ArchiSteamFarm { PICSSemaphore.Release(); } - // ReSharper disable once LoopCanBePartlyConvertedToQuery - C# 7.0 out can't be used within LINQ query yet | https://github.com/dotnet/roslyn/issues/15619 foreach (Dictionary productInfoApps in productInfoResultSet.Results.Select(result => result.Apps)) { if (!productInfoApps.TryGetValue(appID, out SteamApps.PICSProductInfoCallback.PICSProductInfo productInfoApp)) { continue; diff --git a/ArchiSteamFarm/BotConfig.cs b/ArchiSteamFarm/BotConfig.cs index 2a52c6efb..a781cb079 100644 --- a/ArchiSteamFarm/BotConfig.cs +++ b/ArchiSteamFarm/BotConfig.cs @@ -33,8 +33,6 @@ using Newtonsoft.Json; namespace ArchiSteamFarm { [SuppressMessage("ReSharper", "ClassCannotBeInstantiated")] - [SuppressMessage("ReSharper", "ClassNeverInstantiated.Global")] - [SuppressMessage("ReSharper", "ConvertToConstant.Global")] internal sealed class BotConfig { #pragma warning disable 649 [JsonProperty(Required = Required.DisallowNull)] @@ -138,7 +136,6 @@ namespace ArchiSteamFarm { internal readonly string SteamTradeToken; #pragma warning restore 649 - [SuppressMessage("ReSharper", "CollectionNeverUpdated.Global")] [JsonProperty(Required = Required.DisallowNull)] internal readonly Dictionary SteamUserPermissions = new Dictionary(); diff --git a/ArchiSteamFarm/BotDatabase.cs b/ArchiSteamFarm/BotDatabase.cs index dfcbfb462..3a1c59a53 100644 --- a/ArchiSteamFarm/BotDatabase.cs +++ b/ArchiSteamFarm/BotDatabase.cs @@ -24,7 +24,6 @@ using System; using System.Collections.Generic; -using System.Diagnostics.CodeAnalysis; using System.IO; using System.Threading; using System.Threading.Tasks; @@ -59,7 +58,6 @@ namespace ArchiSteamFarm { } // This constructor is used only by deserializer - [SuppressMessage("ReSharper", "UnusedMember.Local")] private BotDatabase() { } public void Dispose() { diff --git a/ArchiSteamFarm/CardsFarmer.cs b/ArchiSteamFarm/CardsFarmer.cs index 3b7822cb7..b31737d12 100755 --- a/ArchiSteamFarm/CardsFarmer.cs +++ b/ArchiSteamFarm/CardsFarmer.cs @@ -968,7 +968,6 @@ namespace ArchiSteamFarm { foreach (Game game in GamesToFarm) { DateTime redeemDate = DateTime.MinValue; if (Program.GlobalDatabase.AppIDsToPackageIDs.TryGetValue(game.AppID, out ConcurrentHashSet packageIDs)) { - // ReSharper disable once LoopCanBePartlyConvertedToQuery - C# 7.0 out can't be used within LINQ query yet | https://github.com/dotnet/roslyn/issues/15619 foreach (uint packageID in packageIDs) { if (!Bot.OwnedPackageIDs.TryGetValue(packageID, out (EPaymentMethod PaymentMethod, DateTime TimeCreated) packageData)) { continue; diff --git a/ArchiSteamFarm/GlobalConfig.cs b/ArchiSteamFarm/GlobalConfig.cs index 70ba232ce..ebcf2a16b 100644 --- a/ArchiSteamFarm/GlobalConfig.cs +++ b/ArchiSteamFarm/GlobalConfig.cs @@ -32,8 +32,6 @@ using SteamKit2; namespace ArchiSteamFarm { [SuppressMessage("ReSharper", "ClassCannotBeInstantiated")] - [SuppressMessage("ReSharper", "ClassNeverInstantiated.Global")] - [SuppressMessage("ReSharper", "ConvertToConstant.Global")] internal sealed class GlobalConfig { internal const byte DefaultConnectionTimeout = 60; internal const ushort DefaultIPCPort = 1242; @@ -52,7 +50,6 @@ namespace ArchiSteamFarm { [JsonProperty(Required = Required.DisallowNull)] internal readonly byte BackgroundGCPeriod; - [SuppressMessage("ReSharper", "CollectionNeverUpdated.Global")] [JsonProperty(Required = Required.DisallowNull)] internal readonly HashSet Blacklist = new HashSet(); @@ -186,10 +183,11 @@ namespace ArchiSteamFarm { MinMemoryUsage } - [SuppressMessage("ReSharper", "UnusedMember.Global")] internal enum EUpdateChannel : byte { None, Stable, + + [SuppressMessage("ReSharper", "UnusedMember.Global")] Experimental } } diff --git a/ArchiSteamFarm/JSON/GitHub.cs b/ArchiSteamFarm/JSON/GitHub.cs index 7a7e3b25e..86159fe93 100644 --- a/ArchiSteamFarm/JSON/GitHub.cs +++ b/ArchiSteamFarm/JSON/GitHub.cs @@ -29,7 +29,6 @@ using Newtonsoft.Json; namespace ArchiSteamFarm.JSON { internal static class GitHub { [SuppressMessage("ReSharper", "ClassCannotBeInstantiated")] - [SuppressMessage("ReSharper", "ClassNeverInstantiated.Global")] internal sealed class ReleaseResponse { #pragma warning disable 649 [JsonProperty(PropertyName = "assets", Required = Required.Always)] diff --git a/ArchiSteamFarm/JSON/Steam.cs b/ArchiSteamFarm/JSON/Steam.cs index cfd11aace..8b04bbe29 100644 --- a/ArchiSteamFarm/JSON/Steam.cs +++ b/ArchiSteamFarm/JSON/Steam.cs @@ -40,7 +40,6 @@ namespace ArchiSteamFarm.JSON { internal uint Amount { get; private set; } [JsonProperty(PropertyName = "appid", Required = Required.DisallowNull)] - [SuppressMessage("ReSharper", "UnusedMember.Local")] internal uint AppID { get; private set; } internal ulong AssetID { get; private set; } @@ -50,7 +49,6 @@ namespace ArchiSteamFarm.JSON { internal EType Type { get; set; } [JsonProperty(PropertyName = "amount", Required = Required.Always)] - [SuppressMessage("ReSharper", "UnusedMember.Local")] private string AmountString { get => Amount.ToString(); @@ -89,7 +87,6 @@ namespace ArchiSteamFarm.JSON { } [JsonProperty(PropertyName = "classid", Required = Required.DisallowNull)] - [SuppressMessage("ReSharper", "UnusedMember.Local")] private string ClassIDString { get => ClassID.ToString(); @@ -108,7 +105,6 @@ namespace ArchiSteamFarm.JSON { } [JsonProperty(PropertyName = "contextid", Required = Required.DisallowNull)] - [SuppressMessage("ReSharper", "UnusedMember.Local")] private string ContextIDString { get => ContextID.ToString(); @@ -128,7 +124,6 @@ namespace ArchiSteamFarm.JSON { } [JsonProperty(PropertyName = "id", Required = Required.DisallowNull)] - [SuppressMessage("ReSharper", "UnusedMember.Local")] private string ID { get => AssetIDString; set => AssetIDString = value; @@ -163,7 +158,6 @@ namespace ArchiSteamFarm.JSON { } [SuppressMessage("ReSharper", "ClassCannotBeInstantiated")] - [SuppressMessage("ReSharper", "ClassNeverInstantiated.Global")] internal sealed class ConfirmationDetails { #pragma warning disable 649 [JsonProperty(PropertyName = "success", Required = Required.Always)] @@ -339,7 +333,6 @@ namespace ArchiSteamFarm.JSON { } [SuppressMessage("ReSharper", "ClassCannotBeInstantiated")] - [SuppressMessage("ReSharper", "ClassNeverInstantiated.Global")] internal sealed class ConfirmationResponse { #pragma warning disable 649 [JsonProperty(PropertyName = "success", Required = Required.Always)] @@ -351,7 +344,6 @@ namespace ArchiSteamFarm.JSON { } [SuppressMessage("ReSharper", "ClassCannotBeInstantiated")] - [SuppressMessage("ReSharper", "ClassNeverInstantiated.Global")] internal sealed class GenericResponse { #pragma warning disable 649 [JsonProperty(PropertyName = "success", Required = Required.Always)] @@ -452,7 +444,6 @@ namespace ArchiSteamFarm.JSON { } [SuppressMessage("ReSharper", "ClassCannotBeInstantiated")] - [SuppressMessage("ReSharper", "ClassNeverInstantiated.Global")] internal sealed class NewDiscoveryQueueResponse { #pragma warning disable 649 [JsonProperty(PropertyName = "queue", Required = Required.Always)] @@ -464,7 +455,6 @@ namespace ArchiSteamFarm.JSON { } [SuppressMessage("ReSharper", "ClassCannotBeInstantiated")] - [SuppressMessage("ReSharper", "ClassNeverInstantiated.Global")] internal sealed class RedeemWalletResponse { #pragma warning disable 649 [JsonProperty(PropertyName = "detail", Required = Required.DisallowNull)] @@ -597,7 +587,6 @@ namespace ArchiSteamFarm.JSON { } } - [SuppressMessage("ReSharper", "UnusedMember.Global")] internal sealed class TradeOfferRequest { [JsonProperty(PropertyName = "me", Required = Required.Always)] internal readonly ItemList ItemsToGive = new ItemList(); diff --git a/ArchiSteamFarm/MobileAuthenticator.cs b/ArchiSteamFarm/MobileAuthenticator.cs index 95f1ed762..58b0d7f1a 100644 --- a/ArchiSteamFarm/MobileAuthenticator.cs +++ b/ArchiSteamFarm/MobileAuthenticator.cs @@ -24,7 +24,6 @@ using System; using System.Collections.Generic; -using System.Diagnostics.CodeAnalysis; using System.Security.Cryptography; using System.Text; using System.Threading; @@ -35,8 +34,6 @@ using HtmlAgilityPack; using Newtonsoft.Json; namespace ArchiSteamFarm { - [SuppressMessage("ReSharper", "ClassCannotBeInstantiated")] - [SuppressMessage("ReSharper", "ClassNeverInstantiated.Global")] internal sealed class MobileAuthenticator : IDisposable { private const byte CodeDigits = 5; private const byte CodeInterval = 30; diff --git a/ArchiSteamFarm/Utilities.cs b/ArchiSteamFarm/Utilities.cs index 948ac7121..53dc5b4a9 100644 --- a/ArchiSteamFarm/Utilities.cs +++ b/ArchiSteamFarm/Utilities.cs @@ -37,8 +37,8 @@ namespace ArchiSteamFarm { internal static class Utilities { private static readonly Random Random = new Random(); - [MethodImpl(MethodImplOptions.AggressiveInlining)] [SuppressMessage("ReSharper", "UnusedParameter.Global")] + [MethodImpl(MethodImplOptions.AggressiveInlining)] internal static void Forget(this object obj) { } internal static string GetCookieValue(this CookieContainer cookieContainer, string url, string name) {